Refuse trailing type parameters in extractors #22699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyouko-taiga
approved these changes
Mar 3, 2025
som-snytt
reviewed
Mar 3, 2025
mbovel
changed the title
Co-authored-by: Dimi Racordon <[email protected]>
odersky
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restrict selection of extractors to ignore methods that have trailing type parameters, as application of these can't be represented with
tpd.UnApply. Fixes #22550.Note: it was discussed during the compiler meeting of 2025-02-26 that
unapplymethods (and other magic methods) should not be linted at definition site, like the first version of this PR did. Instead, non-conforming extractors should crash at use site. This is what this second version implements.