Scala.js: Upgrade to Scala.js 1.18.1. #22397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getClass()` hasn't been a primitive per se for a long time. It is a regular method of `jl.Object` whose *body* uses a primitive operation.
This allows to run two more tests.
And port the changes that were made to the compiler backend. Most notably, the changes from the following upstream PRs: * Introduce non-nullable reference types in the IR. scala-js/scala-js#5018 * Opt: Remove useless *Ident indirections in the IR model. scala-js/scala-js#5092 * Merge the IR node This into VarRef, with a magic LocalName. scala-js/scala-js#5090 * Merge several IR nodes into UnaryOp. scala-js/scala-js#5088 * Restrict usages of StoreModule even further. scala-js/scala-js#5059 * Allow Return arg to be a void if the target Labeled is a void. scala-js/scala-js#5074 * Rename NoType to VoidType and print it as "void". scala-js/scala-js#5061
sjrd
added
the
needs-minor-release
SethTisue
approved these changes
Jan 21, 2025
|
This will be included in 3.7.0 |
|
Also, a question about this PR. Should we try to back port it to LTS without bumping JS version? |
|
No, that's not possible. All the changes in the third commit must be done in lockstep (otherwise I would have made several commits in the first place). You could backport the first two commits of this PR, if you want, but they don't really matter to users. |
|
That's what I suspected, thanks for confirming! I will skip for now since the two commits have only minor changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And port the changes that were made to the compiler backend.
Most notably, the changes from the following upstream PRs:
ThisintoVarRef, with a magicLocalName. scala-js/scala-js#5090UnaryOp. scala-js/scala-js#5088Returnarg to be avoidif the targetLabeledis avoid. scala-js/scala-js#5074Maybe @SethTisue you want to review this one, so you experience what it takes to upgrade Scala.js in this repo? 😅