Super Bootstrap: Make dottydoc part of the bootstrap #2082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixmulder
approved these changes
Mar 12, 2017
|
Heh, this found a bug in dotty! See #2084 |
smarter
force-pushed
the
add/dottydoc-bootstrap
branch
2 times, most recently
from
eb224f4 to
ae10669
Compare
smarter
force-pushed
the
add/dottydoc-bootstrap
branch
8 times, most recently
from
df1a366 to
621befb
Compare
This wasn't done before because dotty could not compile dottydoc, this is now fixed.
smarter
force-pushed
the
add/dottydoc-bootstrap
branch
from
9ee4219 to
d706344
Compare
|
@felixmulder Looks like this is finally green! |
|
Indeed, congrats! |
|
@felixmulder Did you rebase instead of making a merge commit? So far we've always used merge commits and mixing the two styles would be really confusing. Plus, currently we only require the latest commit to pass the tests, as long as we use merge commits this isn't too much of a problem since we can still do bisection based on merge commits, but if we don't have merge commits it becomes impossible to do bisection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wasn't done before because dotty could not compile dottydoc, this
got fixed by PRs #2070 and #2076.