Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion compiler/src/dotty/tools/dotc/typer/Typer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,20 @@ class Typer(@constructorOnly nestingLevel: Int = 0) extends Namer
case Apply(fn, _) if fn.symbol.is(ExtensionMethod) =>
def toSetter(fn: Tree): untpd.Tree = fn match
case fn @ Ident(name: TermName) =>
untpd.cpy.Ident(fn)(name.setterName)
// We need to make sure that the prefix of this extension getter is
// retained when we transform it into a setter. Otherwise, we could
// end up resolving an unrelated setter from another extension. We
// transform the `Ident` into a `Select` to ensure that the prefix
// is retained with a `TypedSplice` (see `case Select` bellow).
// See tests/pos/i18713.scala for an example.
(fn.tpe match
case TermRef(qual: TermRef, _) =>
toSetter(ref(qual).select(fn.symbol).withSpan(fn.span))
case TermRef(qual: ThisType, _) =>
toSetter(This(qual.cls).select(fn.symbol).withSpan(fn.span))
case TermRef(NoPrefix, _) =>
untpd.cpy.Ident(fn)(name.setterName)
): @annotation.nowarn // false-positive match exhastivity warning
case fn @ Select(qual, name: TermName) =>
untpd.cpy.Select(fn)(untpd.TypedSplice(qual), name.setterName)
case fn @ TypeApply(fn1, targs) =>
Expand Down
18 changes: 18 additions & 0 deletions tests/pos/i18713.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import language.experimental.relaxedExtensionImports

class A
object AA:
extension (a: A)
def f = ???
def f_=(x: String) = ???

object BB:
extension (b: Long)
def f = ???
def f_=(x: String) = ???

def test(a: A) =
import AA.*
import BB.*
a.f
a.f = "aa"