Skip to content

Backport "Fix false positive in WUnused for renamed path-dependent imports (2)" to LTS #20637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Backport "Fix false positive in WUnused for renamed path-dependent imports (2)" to LTS #20637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions compiler/src/dotty/tools/dotc/transform/CheckUnused.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,7 @@ object CheckUnused:
* - usage
*/
private class UnusedData:
import collection.mutable.{Set => MutSet, Map => MutMap, Stack => MutStack}
import collection.mutable.{Set => MutSet, Map => MutMap, Stack => MutStack, ListBuffer => MutList}
import UnusedData.*

/** The current scope during the tree traversal */
Expand All @@ -346,7 +346,7 @@ object CheckUnused:
var unusedAggregate: Option[UnusedResult] = None

/* IMPORTS */
private val impInScope = MutStack(MutSet[tpd.Import]())
private val impInScope = MutStack(MutList[tpd.Import]())
/**
* We store the symbol along with their accessibility without import.
* Accessibility to their definition in outer context/scope
Expand Down Expand Up @@ -449,7 +449,7 @@ object CheckUnused:
def pushScope(newScopeType: ScopeType): Unit =
// unused imports :
currScopeType.push(newScopeType)
impInScope.push(MutSet())
impInScope.push(MutList())
usedInScope.push(MutSet())

def registerSetVar(sym: Symbol): Unit =
Expand Down
10 changes: 10 additions & 0 deletions tests/pos/i18366.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
//> using options -Xfatal-warnings -Wunused:all

trait Builder {
def foo(): Unit
}

def repro =
val builder: Builder = ???
import builder.{foo => bar}
bar()