Add init test #20356
Merged
Add init test #20356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
reviewed
May 8, 2024
tests/warn/TypeCast.scala
Outdated
| @@ -4,7 +4,7 @@ object A { | |||
| } | |||
| object B { | |||
| val f: Int = g() | |||
| def g(): Int = f // error | |||
| def g(): Int = f // warn | |||
There was a problem hiding this comment.
Should this file be in tests/init-global/warn instead of just tests/warn?
There was a problem hiding this comment.
It turns out that we already have it here: https://github.com/scala/scala3/blob/main/tests/init-global/warn/TypeCast.scala
So we can simply remove the duplicate file.
| val names = Set("bla") | ||
| val help = "bla" | ||
|
|
||
| val opts = List(OptMinSuccess) // warn |
There was a problem hiding this comment.
I'm getting Warnings found on incorrect row numbers when compiling tests/init-global/warn/ScalaCheck.scala when I run the test. The warning is on line 16, then has a trace that ends on 21.
liufengyun
force-pushed
the
fliu/add-init-test
branch
from
cab415f to
67c68b8
Compare
liufengyun
added a commit
that referenced
this pull request
Oct 8, 2024
Add Color.scala to black list The test added in #20356 seems to break `test_scala2_library_tasty`, due to a [problem](scala/bug#13009) in Scala 2 library. [test_scala2_library_tasty]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add init test