Fix #2024: TypeApply can be a final apply of a recursive method. #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixmulder, is our CI dead? |
|
@nicolasstucki please review. |
| (if (mirrorC ne null) mirrorC else plainC).visitAttribute(dataAttr) | ||
| val store = if (mirrorC ne null) mirrorC else plainC | ||
| store.visitAttribute(dataAttr) | ||
| if (ctx.settings.emitTasty.value) { |
There was a problem hiding this comment.
This does not seem to be relevant to this PR as -XemitTasty is never enabled.
It saves tasty output near the class file output to a *.tasty-file.
nullary methods with type parameters were handled wrongly, which led to absence of type application and a cryptic error message.
|
Let's make it a -Y option? |
| @@ -44,6 +44,7 @@ class ScalaSettings extends Settings.SettingGroup { | |||
| /** -X "Advanced" settings | |||
| */ | |||
| val Xhelp = BooleanSetting("-X", "Print a synopsis of advanced options.") | |||
| val emitTasty = BooleanSetting("-XemitTasty", "Generate tasty in separate *.tasty file.") | |||
There was a problem hiding this comment.
You should probably make it a -Y option or remove it from this PR.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nullary methods with type parameters were handled wrongly, which led to
absence of type application and a cryptic error message.