Workaround #19542 #19561
Merged
Workaround #19542 #19561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable `tests/neg/i8984.scala`. * Fix broken tests
odersky
approved these changes
Jan 29, 2024
This was referenced Jan 30, 2024
nicolasstucki
added a commit
that referenced
this pull request
Jan 30, 2024
…19566) Part of #19542. We protect against the case where `Exception.getMessage` or `Exception.getStackTrace` throw an exception. This change makes `testCompilation tests/neg/i8984.scala` fail as expected. `tests/neg/i8984.scala` is currently disabled (see #19561). `tests/neg/i8984.scala` will not be fixed in this PR. Making the test framework more resilient is a priority. Fixing this is the last part of #19542.
|
This kind of failure will not happen anymore. #19566 patched the test framework. |
WojciechMazur
added a commit
that referenced
this pull request
Jun 28, 2024
Backports #19561 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tests/neg/i8984.scala(see #19542)