Skip to content

Fix issue #17465 #17627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix issue #17465 #17627

wants to merge 1 commit into from

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented May 30, 2023

Fix issue #17465

@Linyxus
Copy link
Contributor

Linyxus commented May 30, 2023

test performance please

@nicolasstucki
Copy link
Contributor

What is the status of this PR? Did this fix work? Were there concerns about performance?

@mbovel what is the status of the benchmarking bot/machine?

The PR is missing a test for #17465.

@mbovel
Copy link
Member

mbovel commented Jul 13, 2023

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@Linyxus
Copy link
Contributor

Linyxus commented Jul 14, 2023

Duplicate of #18213.

@Linyxus Linyxus closed this Jul 14, 2023
@mbovel
Copy link
Member

mbovel commented Jul 17, 2023

test performance please

@dottybot
Copy link
Member

performance test scheduled: 239 job(s) in queue, 1 running.

@mbovel
Copy link
Member

mbovel commented Jul 17, 2023

(I know this PR won't be merged, but I am testing the benchmarks bot again. Not sure why it did not work last time.)

@dottybot
Copy link
Member

Performance test finished successfully:

Visit https://dotty-bench.epfl.ch/17627/ to see the changes.

Benchmarks is based on merging with main (2753a17)

@mbovel
Copy link
Member

mbovel commented Jul 17, 2023

Oh, well, seems to work now.

@hamzaremmal hamzaremmal deleted the patch-i17465 branch November 14, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants