Skip to content

Refactor: Redirection to boundary/break instead of scala.util.control.NonLocalReturns #17583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2023
Merged

Refactor: Redirection to boundary/break instead of scala.util.control.NonLocalReturns #17583

merged 1 commit into from
May 25, 2023

Conversation

Dedelweiss
Copy link
Contributor

Screenshot 2023-05-25 at 14 31 01

Fixes: #17572

@julienrf
Copy link
Contributor

Sorry for the confusion but this is not the right file to edit :) You should edit the one that is in docs/_docs, not docs/_spec.

bishabosha
bishabosha requested changes May 25, 2023
View reviewed changes
Copy link
Member

@bishabosha bishabosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you also base this PR on the language-reference-stable branch

@Dedelweiss Dedelweiss force-pushed the 17572-boundary-doc branch 2 times, most recently from a541ae0 to 7bdd5c7 Compare May 25, 2023 13:18
@Dedelweiss Dedelweiss changed the base branch from main to language-reference-stable May 25, 2023 13:27
@Dedelweiss Dedelweiss changed the base branch from language-reference-stable to main May 25, 2023 13:29
@Dedelweiss Dedelweiss force-pushed the 17572-boundary-doc branch from 7bdd5c7 to 3502cef Compare May 25, 2023 13:32
@Dedelweiss Dedelweiss changed the base branch from main to language-reference-stable May 25, 2023 13:32
@Dedelweiss Dedelweiss requested a review from bishabosha May 25, 2023 13:35
@Dedelweiss
Copy link
Contributor Author

Is it good? Sorry for the confusion about the file and thanks for the feedback.

@bishabosha bishabosha merged commit 5425919 into scala:language-reference-stable May 25, 2023
@bishabosha
Copy link
Member

Thank you for making the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bishabosha bishabosha bishabosha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document boundary/break
3 participants
@Dedelweiss @julienrf @bishabosha