Skip to content

Fix order in which errors are reported for assignment to val #16660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

Fix order in which errors are reported for assignment to val #16660

merged 1 commit into from
Jan 11, 2023

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Jan 11, 2023

Fixes #16655

@odersky odersky requested a review from soronpo January 11, 2023 12:52
soronpo
soronpo approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@soronpo soronpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@odersky odersky merged commit ed81385 into scala:main Jan 11, 2023
@odersky odersky deleted the fix-16655 branch January 11, 2023 19:23
@Kordyjan Kordyjan added this to the 3.3.0 milestone Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soronpo soronpo soronpo approved these changes

Assignees

@soronpo soronpo

Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Report val reassignment before typecheck errors
3 participants
@odersky @soronpo @Kordyjan