Partial revert of #13780 #15341
Merged
Partial revert of #13780 #15341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
reviewed
May 31, 2022
| @@ -42,6 +42,7 @@ i9999.scala | |||
| 13491.scala | |||
| 7512.scala | |||
| i6505.scala | |||
| i15155.scala | |||
There was a problem hiding this comment.
Why adding this test to the blacklist? Isn't it supposed to pass after reverting the changes?
There was a problem hiding this comment.
There are many matchtype tests that fail pickling. Someone should find and fix the cause. Previously the test was a neg test, so no pickling was attempted.
scala#13780 caused several regressions and I think it is too restrictive as a fix. I am reverting it an re-opening the original scala#11982 issue. It would be good to get to the bottom of what the soundness problem hinted at in scala#11982 is, and what a fix should be. As it stands scala#11982 is not obviously a soundness problem but a separate compilation problem.
prolativ
approved these changes
May 31, 2022
odersky
added
the
backport:nominated
Kordyjan
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13780 caused several regressions and I think it is too restrictive as a fix.
I am reverting it and will be re-opening the original #11982 issue.
It would be good to get to the bottom of what the soundness problem hinted at
in #11982 is, and what a fix should be. As it stands #11982 is not obviously
a soundness problem but a separate compilation problem.
If the necessary fix is as restrictive as the one I reverted, we should wait until 3.2 to add it.
Fixes #15319
Also solves #15155 and reclassifies it as a pos test.
This is a more sweeping alternative of #15337. #15337 also fixes #15319 but leaves #15155 as an error.