Skip to content

Use hasSameLength #15270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2022
Merged

Use hasSameLength #15270

merged 1 commit into from
Jun 7, 2022

Conversation

@dwijnand
Copy link
Member

@dwijnand dwijnand commented May 23, 2022

No description provided.

@dwijnand dwijnand marked this pull request as ready for review June 3, 2022 12:50
@dwijnand dwijnand assigned nicolasstucki and unassigned dwijnand Jun 6, 2022
@TheElectronWill
Copy link
Contributor

TheElectronWill commented Jun 7, 2022 •
edited
Loading

hasSameLengthAs uses @tailrec, I wonder if that makes a difference here 🤔 (probably not, but now I also wonder if I can start a benchmark...)

@TheElectronWill
Copy link
Contributor

TheElectronWill commented Jun 7, 2022

test performance please

@TheElectronWill TheElectronWill self-requested a review June 7, 2022 10:33
@som-snytt
Copy link
Contributor

som-snytt commented Jun 7, 2022

On an unrelated PR, someone asked about if vs pattern match, and also method call vs type test. ("There are more bytecodes.") It would be nice if there were a canonical reference for a preferred idiom.

nicolasstucki
nicolasstucki approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@dwijnand dwijnand enabled auto-merge June 7, 2022 14:52
@dwijnand dwijnand merged commit 76a0b29 into scala:main Jun 7, 2022
@dwijnand dwijnand deleted the same-length branch June 10, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

@TheElectronWill TheElectronWill TheElectronWill approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dwijnand dwijnand

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dwijnand @TheElectronWill @som-snytt @nicolasstucki