Skip to content

fix 14150 - constrain refinements to type parameters #15014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2022

Conversation

bishabosha
Copy link
Member

@bishabosha bishabosha commented Apr 22, 2022

constrain the synthesised refinements to the product/sum type against the formal before the intersection

closes #14150

@smarter
Copy link
Member

smarter commented Apr 22, 2022

It seems like there's a code generation bug in this code (#14150 (comment)), so I think this needs to be fixed first before looking into inference (in fact, fixing the generated code might also fix the inference here)

@bishabosha bishabosha force-pushed the fix-14150 branch 2 times, most recently from 336d7f8 to f52a1a8 Compare April 25, 2022 09:36
@bishabosha
Copy link
Member Author

It seems like there's a code generation bug in this code (#14150 (comment)), so I think this needs to be fixed first before looking into inference (in fact, fixing the generated code might also fix the inference here)

ok it works! will need to generalise from this point

@bishabosha bishabosha force-pushed the fix-14150 branch 4 times, most recently from 7dc5235 to 11eac65 Compare May 16, 2022 07:55
@bishabosha bishabosha marked this pull request as ready for review May 16, 2022 07:55
@bishabosha bishabosha changed the title wip: fix 14150 - constrain refinements to type parameters fix 14150 - constrain refinements to type parameters May 16, 2022
@bishabosha bishabosha requested a review from dwijnand May 16, 2022 07:57
@bishabosha bishabosha added this to the 3.2.0-RC1 milestone May 16, 2022
record constraints against the formal.
@dwijnand dwijnand merged commit 55b47f6 into scala:main May 31, 2022
@dwijnand dwijnand deleted the fix-14150 branch May 31, 2022 10:18
@bishabosha bishabosha added the release-notes Should be mentioned in the release notes label May 31, 2022
@Kordyjan Kordyjan modified the milestones: 3.2.0-RC1, 3.2.0 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:typeclass-derivation release-notes Should be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MirroredElemLabels of Mirror.Sum inferred to be EmptyTuple
4 participants