Add Expr.ofFunction1 #14138
Closed
Add Expr.ofFunction1 #14138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
reviewed
Dec 19, 2021
Co-authored-by: Dale Wijnand <[email protected]>
|
I think we should mark this as |
| * to an expression equivalent to | ||
| * `'{ $a => $r }` typed as an `Expr[A => R]` | ||
| */ | ||
| def ofFunction1[A, R](f: Expr[A] => Expr[R])(using Type[R], Type[A])(using Quotes): Expr[A => R] = |
There was a problem hiding this comment.
If we add this we should add it for all function arities. It seems that we would need TupledFunction (see #10416) to be able to write this interface for all function sizes.
prolativ
reviewed
Dec 29, 2021
| * Transforms the expression | ||
| * `a => r` where `a: Expr[A]` and `r: Expr[R]` | ||
| * to an expression equivalent to | ||
| * `'{ $a => $r }` typed as an `Expr[A => R]` |
There was a problem hiding this comment.
As you're adding a new method to stdlib's API you should mark it as@experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.