-
Notifications
You must be signed in to change notification settings - Fork 1.1k
13097: Fix FewerBraces eta expansion error #14092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is ready for review. @griggt |
Hey @gagandeepkalra, I'm sorry this has taken so long to get a review on 😆 Is this something you're still willing to push over the finish line? If so, can you rebase and then we can get you a review on this. |
The ticket (which was mine, thanks for addressing) saw other duplicates and finally a fix that was merged. I haven't compared the solutions to see if this PR offers something else to preserve. What year is this anyway? |
haha, no worries. Since the original issue is closed now I'll go ahead and close this one as well. Thanks again for creating this @gagandeepkalra, I'm sure it helped with the prs that fixed the issue. @som-snytt if it turns out that something is still missing from your report or this brings in something else additionally, please to cherry pick it or report it and we can re-address. |
I will try to add the repl test, for fun and profit. I will co-author gagandeepkalra . I wonder what he is doing these days. Oh, I see Seth follows him, so I'll ask Seth. |
Follow-up #16466 with test from #14092 which was sadly ignored. Co-authored-by: Gagandeep kalra <[email protected]>
resolves 13097
@griggt