Add SkolemType in metaprogramming #13579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soronpo
added
area:metaprogramming
needs-minor-release
|
We should not have skolems in this API. TASTY widens all skolems, hence we should do the same. If we see a skolem it is a bug invovling a missing |
|
Ok, then what if I remove the public API but leave the printing to avoid a compiler crash or alternatively throw an error with more details on the skolem? |
|
A fix for one instance of the skolem issue in available in #13748. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an error that somehow got a
SkolemTypeduring type-dependent metaprogramming.Because it was not handled, I got a match type error during
.show.Therefore I added
SkolemType, similarly to the other types.A few questions:
SkolemTypebe available, or should we just handle the.showuse-case?.showI chose to print it as$skolem[info]. Is there a better alternate suggestion?