Remove anomalies and gaps in handling annotations #13474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
added
the
cc-experiment
Always print annotation arguments if there are some, except for Body annotations
A TypeMap previously mapped the annotation only if it returned a different result for the parent type. There is no good reason for this behavior. We now map always, but allow the mapping operation to be defined in the annotation. The change uncovers a bug illustrated in annotDepMethType.scala, which is fixed in the next commit.
Fix problems handling function types that are dependent through their result annotations.
odersky
force-pushed
the
cc-experiment
branch
from
7eaa65c to
a38c98e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR analogous to #13348 but for cc-experiment