Add Symbol.allMembers to reflection API #13391
Conversation
| @@ -3652,6 +3652,9 @@ trait Quotes { self: runtime.QuoteUnpickler & runtime.QuoteMatching => | |||
| /** All members directly declared in the class */ | |||
| def declarations: List[Symbol] | |||
|
|
|||
| /** All members declared or inherited */ | |||
| def allMembers: List[Symbol] | |||
There was a problem hiding this comment.
Like in the documentation of Type#allMembers, we should mention that this can be slow to compute.
There was a problem hiding this comment.
We need then to update other methods documentation that use in their implementation Type#allMembers
There was a problem hiding this comment.
Even better would be to fix these methods to not call allMembers :) Instead, we should be able to use memberDenots in most cases
There was a problem hiding this comment.
We should make this an iterator. We already do this for allOverriddenSymbols which has a similar complexity.
There was a problem hiding this comment.
This method should also be marked as @experimental
|
Part of #13371 |
nicolasstucki
force-pushed
the
add-allMembers
branch
from
5c66118 to
a2bc3e3
Compare
| @@ -2603,6 +2603,13 @@ class QuotesImpl private (using val ctx: Context) extends Quotes, QuoteUnpickler | |||
| def declarations: List[Symbol] = | |||
| self.typeRef.info.decls.toList | |||
|
|
|||
| def allMembers: List[Symbol] = | |||
| lookupPrefix.allMembers.iterator.map(_.symbol).collect { | |||
There was a problem hiding this comment.
Based on the test I added, the order of the members is not deterministic.
|
For now, we'll stick to internal compiler API in terms of this method. |
No description provided.