[Backport] Avoid crash by relaxing TyperState assertion #13296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flushing a reporter might force error messages (in particular when a StoreReporter is flushed into a non-StoreReporter), and the TyperState of the context captured in an error message might already be committed at this point. In ea6449f I tried to deal with this by flushing before committing but that's not sufficient since the reporter we're flushing might contain error messages from a more deeply nested TyperState. So this commit just relaxes the assertion (ideally we would also check that only TyperStates created in a committed TyperState can be committed in one, but keeping track of that would require an extra field in TyperState).
dwijnand
approved these changes
Aug 16, 2021
|
Hi, does this mean that 3.0.2-RC1 should have this fix? I have a similar bug that repros against the RC but don't want to waste people's time if it's already fixed |
|
err, nevermind, reproed in RC2 which clearly should have the fix. I will file a bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #13150 which fixes a regression introduced in 3.0.1.