Don't let caseLambda bindings accumulate in constraint #12320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 1 running. |
|
@OlivierBlanvillain Test 6697 started failing. But arguably the error is correct. So it was wrong before. Do you agree? |
|
Performance test finished successfully: Visit https://dotty-bench.epfl.ch/12320/ to see the changes. Benchmarks is based on merging with master (1440699) |
OlivierBlanvillain
approved these changes
May 4, 2021
There was a problem hiding this comment.
Yes I agree. I think this PR is a duplicate of #9108, I've just pushed the extra test cases to this branch to see if they also pass here.
|
Yes, I see now this is a duplicate of #9108. I notice that 9890.scala fails in both PRs, so that test should be removed. |
Remove them when a `matchCases` has finished.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove them when a
matchCaseshas finished.Fixes #9107