Skip to content

Update macro code in shapeless #12175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2021
Merged

Update macro code in shapeless #12175

merged 1 commit into from
Apr 22, 2021

Conversation

nicolasstucki
Copy link
Contributor

No description provided.

@nicolasstucki nicolasstucki marked this pull request as ready for review April 22, 2021 08:48
liufengyun
liufengyun approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

/cc: @milessabin

@milessabin
Copy link
Contributor

Thanks! Can you PR that against https://github.com/milessabin/shapeless/tree/shapeless-3.

@nicolasstucki
Copy link
Contributor Author

@milessabin I will open the PR.

@nicolasstucki nicolasstucki merged commit 32e725f into scala:master Apr 22, 2021
@nicolasstucki nicolasstucki deleted the refactor-macro-code-shapeless branch April 22, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @milessabin @liufengyun