Fix #10883: Override line and column in NoSourcePosition
#11362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits constructing tests that depend on particular command line options such as `-Xprint:typer`
Otherwise, usage causes an assertion error. The use of the value -1 is in agreement with the documentation in interfaces/src/dotty/tools/dotc/interfaces/SourcePosition.java The REPL driver depends on these methods for ordering its output, and some diagnostics are reported (intentionally) using NoSoucePosition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REPL driver uses the
lineandcolumnmethods ofSourcePositionfor ordering its output, however there are several diagnostics that are reported usingNoSourcePosition, for example:https://github.com/lampepfl/dotty/blob/a63b1d114179d79be32a1ee6552fc160c1bb2410/compiler/src/dotty/tools/dotc/Run.scala#L256
https://github.com/lampepfl/dotty/blob/a63b1d114179d79be32a1ee6552fc160c1bb2410/compiler/src/dotty/tools/dotc/core/SymbolLoaders.scala#L345
This was working until the
SourcePositionimplementation was changed in #10363, after which calls tolineorcolumnonNoSourcePositionresulted in an assertion error rather than returning -1 in accordance with:https://github.com/lampepfl/dotty/blob/a63b1d114179d79be32a1ee6552fc160c1bb2410/interfaces/src/dotty/tools/dotc/interfaces/SourcePosition.java#L20-L23
Fixes #10883
Fixes #9111 (previously fixed by #9351, broken again by #10363)