Improvements & bugs that were discovered while implementing specialization. #1104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dotty-staging@89386d0 and dotty-staging@1379208 should have tests. |
|
@smarter dotty-staging@89386d0 cannot be tested by a source file as this is the usage of internal helper-API that previously was supported and now requires using more low-level api. Speaking about dotty-staging@1379208 - I'm not sure if there can be a test that does not need specialization at the moment. I believe that those changes generally improve robustness of compiler and are worth getting in. |
|
Otherwise LGTM |
|
@DarkDimius Do you want to do the final changes to get this in now? |
DarkDimius
force-pushed
the
spec-bugs
branch
2 times, most recently
from
5cb08c3 to
b8c0478
Compare
Just like normal accessors.
Otherwise can create trees that do not pas Ycheck.
dropEmpty is not as clear, as it does not indicate what it drops. Additionally makes phaseName by in sync with class name.
There were two sources of inefficiency in previous scheme: - if symbol was no overriding anything the forwarder was still being created - the class that is will have the forwarder was not considered. Many methods do not require forwarders as JVM will dispatch correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big one is the change in mixin.
It reduces the size of dotty.jar by 4%.