Fix #10614: align unchecked pattern definition syntax with Scala 2 #10793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liufengyun
force-pushed
the
fix-10614
branch
3 times, most recently
from
fd879a8 to
dd8a2af
Compare
liufengyun
force-pushed
the
fix-10614
branch
from
dd8a2af to
b3cff8b
Compare
The test case is tests/neg/deferred-patdef.scala
liufengyun
force-pushed
the
fix-10614
branch
from
4b620c2 to
276cf27
Compare
b-studios
reviewed
Dec 15, 2020
b-studios
approved these changes
Dec 15, 2020
1. Warnings are more consistent with exhaustivity check where only warnings are issued 2. Errors are not friendly for prototyping, where the programmer makes assumptions about what values are possible.
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 15, 2021
After scala#10793, we can perform the check in 3.0
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 18, 2021
After scala#10793, we can perform the check in 3.0
liufengyun
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jan 18, 2021
After scala#10793, we can perform the check in 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10614: align unchecked pattern definition syntax with Scala 2