Fix #10681: Reject applied HK types in term positions #10774
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this change makes a lot of sense by itself, but while this PR was open #10784 was merged which completely changed the way creator application is implemented to be based on synthetic apply methods instead of a fallback in typer (to avoid accidentally falling back in case of ambiguity errors for example), so this PR isn't necessary anymore, but thank you for taking the time to work on it and we may come back to it if #10784 ends up being reverted! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typedFunPartinApplications.scalashould only adapt E to new E when we're applying E to some term parameters.Fixes #10681.
Also fixes #10679.
Thanks @liufengyun and @smarter for help :)