Fix source-dependencies/macro-expansion-dependencies-2 #10488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 80ed86a we removed some explicit parameter names which made incremental compilation behave diferently than what the original test expected. At some point, the macro implementation failed to compile which regiseted as a success for `-> compile`. Now we test that the macros compile before testing the error that they emit.
liufengyun
approved these changes
Nov 25, 2020
|
|
||
| $ copy-file changes/MacroRuntimeRuntimeError.scala MacroRuntime.scala | ||
| > clean | ||
| > compile |
There was a problem hiding this comment.
It seems to simply repeat the same steps as in the first section.
There was a problem hiding this comment.
The first checks that MacroRuntimeCompileError compiles and the second checks that MacroRuntimeRuntimeError compiles. Notice the RuntimeCompile/RuntimeRuntime in the file names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 80ed86a we removed some explicit parameter names which made incremental compilation behave differently than what the original test expected.
At some point, the macro implementation failed to compile which registered as a success for
-> compile. Now we test that the macros compile before testing the error that they emit.This is a follow up of #10467.
[test_sbt]