Fix #10466: Update rootPosition to Position.ofMacroExpansion

[nicolasstucki]

[test_sbt]

[nicolasstucki]

We need to fix this one to be able to publish 3.0.0-M2

[liufengyun]

LGTM

[griggt]

In order to get the test to pass locally, I had to give a name to the context parameter:

diff --git a/sbt-dotty/sbt-test/source-dependencies/macro-expansion-dependencies-2/changes/MacroRuntimeRuntimeError.scala b/sbt-dotty/sbt-test/source-dependencies/macro-expansion-dependencies-2/changes/MacroRuntimeRuntimeError.scala
index caa79c3d24..e917a255af 100644
--- a/sbt-dotty/sbt-test/source-dependencies/macro-expansion-dependencies-2/changes/MacroRuntimeRuntimeError.scala
+++ b/sbt-dotty/sbt-test/source-dependencies/macro-expansion-dependencies-2/changes/MacroRuntimeRuntimeError.scala
@@ -2,7 +2,7 @@ import scala.quoted._

 object MacroRuntime {

-   def impl()(using Quotes): Expr[Unit] = {
+   def impl()(using q: Quotes): Expr[Unit] = {
       '{ ??? }
    }

I have no idea why that makes a difference here.

[nicolasstucki]

That changes the signature in one of the steps, which may trigger the incremental compilation recompile more.

[griggt]

Ah, that must be it. Adding a > clean before the final -> run in the test script seems to work also.

[nicolasstucki]

This means that there was a regression in the incremental compilation of macros. I added the clean to unblock the release. I'm bisecting the commit to find the source of the problem and will open an issue when I find it.

@liufengyun could you have a last look at the changes I added?

[liufengyun]

This means that there was a regression in the incremental compilation of macros. I added the clean to unblock the release. I'm bisecting the commit to find the source of the problem and will open an issue when I find it.

@liufengyun could you have a last look at the changes I added?

It looks good to me.

[nicolasstucki]

It looks like 80ed86a is the first commit to fail