Fix #9783: Scala.js: Implement the -scalajs-mapSourceURI option.
#10439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We apply it to the scala3-library-bootstrappedJS project, so that source maps can correctly work for the Scala 3 library. Additionally, it serves as a smoke test.
nicolasstucki
approved these changes
Nov 22, 2020
smarter
reviewed
Nov 24, 2020
| @@ -67,6 +67,7 @@ class ScalaSettings extends Settings.SettingGroup { | |||
|
|
|||
| /** Scala.js-related settings */ | |||
| val scalajsGenStaticForwardersForNonTopLevelObjects: Setting[Boolean] = BooleanSetting("-scalajs-genStaticForwardersForNonTopLevelObjects", "Generate static forwarders even for non-top-level objects (Scala.js only)") | |||
| val scalajsMapSourceURI: Setting[List[String]] = MultiStringSetting("-scalajs-mapSourceURI", "uri1[->uri2]", "rebases source URIs from uri1 to uri2 (or to a relative URI) for source maps (Scala.js only)") | |||
There was a problem hiding this comment.
To simplify cross-compilation and not have to update the existing documentation, would it make sense to make -P:scalajs:foo an alias of -scalajs-foo ?
There was a problem hiding this comment.
How would we do that? -P is a generic system to pass options to a plugin. We would have to special case scalajs in several places.
There was a problem hiding this comment.
I haven't looked at how -P works so I can't say, but it seems like even if it's a bit hacky it would be worth it, but I don't know, your choice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We apply it to the scala3-library-bootstrappedJS project, so that source maps can correctly work for the Scala 3 library.
Additionally, it serves as a smoke test.