Skip to content

Move Reflection into QuoteContext #10350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

Move Reflection into QuoteContext #10350

merged 1 commit into from
Nov 17, 2020

Conversation

nicolasstucki
Copy link
Contributor

  • Make Reflection the module class of QuoteContext.reflect

@nicolasstucki nicolasstucki self-assigned this Nov 17, 2020
@nicolasstucki nicolasstucki force-pushed the move-Reflection-into-QuoteContext branch 2 times, most recently from 2e6b02c to 3d189c7 Compare November 17, 2020 08:19
@nicolasstucki
Move Reflection into QuoteContext
3115bfc 
* Make Reflection the module class of QuoteContext.reflect
@nicolasstucki nicolasstucki force-pushed the move-Reflection-into-QuoteContext branch from 3d189c7 to 3115bfc Compare November 17, 2020 08:27
liufengyun
liufengyun approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicolasstucki nicolasstucki marked this pull request as ready for review November 17, 2020 10:16
@nicolasstucki nicolasstucki merged commit cd15c99 into scala:master Nov 17, 2020
@nicolasstucki nicolasstucki deleted the move-Reflection-into-QuoteContext branch November 17, 2020 10:17
@Kordyjan Kordyjan added this to the 3.0.0 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@nicolasstucki nicolasstucki

Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolasstucki @liufengyun @Kordyjan