Fix #10107: Improve inline if constant condition detraction and reporting
#10114
Conversation
nicolasstucki
changed the title
inline ifinline if constant condition detraction and reporting
nicolasstucki
changed the title
inline if constant condition detraction and reportinginline if constant condition detraction and reporting
| errorTree(tree, em"""cannot reduce inline if | ||
| | its condition ${tree.cond} | ||
| | is not a constant value""") | ||
| errorTree(tree, em"""Cannot reduce `inline if` with non constant value. |
There was a problem hiding this comment.
I think the old error message is clearer.
There was a problem hiding this comment.
The issue with the previous message is that the condition is printed in the middle of the message. That condition may be long or have several lines. Ideally we should have a message where the tree is printed last.
There was a problem hiding this comment.
Cannot reduce `inline if` because its condition is not a constant value:
$cond1
I keep meaning to see that Ralph Fiennes movie, "The Constant Gardener."
If we could use that title for a narrative about compilation, then we'd have the same problem as that other Fiennes movie, "The English Patient," whether to emphasize the adjective or the noun.
The suggested edit avoids "non constant" --> "non-constant" --> "inconstant" discussion.
There was a problem hiding this comment.
I used "Cannot reduce `inline if` because its condition is not a constant value: $cond".
There was a problem hiding this comment.
OK, I see the reasoning now.
Showing the reduced condition is much more useful than showing the original condition.
nicolasstucki
force-pushed
the
fix-#10107
branch
from
57dcc2c to
af9cf43
Compare
Showing the reduced condition is much more useful than showing the original condition.