Skip to content

stdlib-sourcelinks-test is failing some of the time on PRs opened against release-3.0.1 branch #12882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
smarter opened this issue Jun 19, 2021 · 6 comments · Fixed by #12895
Closed
Assignees
Milestone

Comments

@smarter
Copy link
Member

smarter commented Jun 19, 2021

See #12873 and #12845 which both failed with:

Error: Test dotty.tools.scaladoc.sourcelinks.RemoteLinksTest.runTest failed: Expected to find Predef at scala/[email protected]/src/library/scala/Predef.scala at line 96, took 3.607 sec

@BarkingBad
Copy link
Contributor

I'll fix it tomorrow ASAP.

However, problem with positions of/in Predef exists for a long time and we should investigate it deeper to find the root cause.

@odersky
Copy link
Contributor

odersky commented Jun 22, 2021

It's probably because Predef is not a regular file but is patched.

@BarkingBad
Copy link
Contributor

Could you elaborate on how is it patched? I would like to resolve this issue since it came over too many times

@BarkingBad
Copy link
Contributor

BarkingBad commented Jun 22, 2021

@smarter I think the PRs weren't rebased, there is PR merged by Krzysztof that disables Predef from testing, and I see that CI on master succeedes. For now I would leave it as a work around and will look into positions themselves to fix them in the near future.

@smarter
Copy link
Member Author

smarter commented Jun 22, 2021

This issue is about the release-3.0.1 branch, the PR you linked to needs to be backported to that branch.

@BarkingBad BarkingBad linked a pull request Jun 22, 2021 that will close this issue
@anatoliykmetyuk
Copy link
Contributor

Backported, closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants