Skip to content

Backport "Fix for #22461 Empty ClassPath attribute in one or more classpath jars causes crash" to 3.3 LTS #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 23, 2025
Merged

Backport "Fix for #22461 Empty ClassPath attribute in one or more classpath jars causes crash" to 3.3 LTS #263

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
633f1da
replaced previous commits with a cp filter in Jar.scala
philwalk Feb 21, 2025
13b6b8c
chore: Apply suggestions from code review
hamzaremmal Feb 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/io/Jar.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class Jar(file: File) {
def mainClass: Option[String] = manifest.map(_(Name.MAIN_CLASS))
/** The manifest-defined classpath String if available. */
def classPathString: Option[String] =
for (m <- manifest ; cp <- m.attrs.get(Name.CLASS_PATH)) yield cp
for (m <- manifest ; cp <- m.attrs.get(Name.CLASS_PATH) if !cp.trim().isEmpty()) yield cp
def classPathElements: List[String] = classPathString match {
case Some(s) => s.split("\\s+").toList
case _ => Nil
Expand Down