-
Notifications
You must be signed in to change notification settings - Fork 47
replace Travis-CI with GitHub Actions #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0ff1ed6
to
4957a71
Compare
@Sciss I am also adding the publishing secrets to the GitHub Actions settings, so we should be all set to go for publishing. I don't think we need to test that aspect... if it doesn't work when the time comes, we'll deal with it. |
|
||
// We use <epoch>.<major>.<minor> like 99% of Scala libraries. | ||
// Versions are binary compatible within x.y.* but not within x.*.* | ||
ThisBuild / versionScheme := Some("pvp") | ||
ThisBuild / versionPolicyIntention := Compatibility.None // 3.0.0 | ||
|
||
lazy val commonSettings = Seq( | ||
scalacOptions ++= Seq("-deprecation", "-feature"), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt-scala-module sets these, so we don't need to
.settings( | ||
scalaVersion := (swing / scalaVersion).value, | ||
run / fork := true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confident this isn't needed
@@ -1,2 +1 @@ | |||
addSbtPlugin("org.scala-lang.modules" % "sbt-scala-module" % "2.3.0") | |||
addSbtPlugin("ch.epfl.scala" % "sbt-version-policy" % "1.0.1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sbt-scala-module now includes sbt-version-policy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
and: * upgrade sbt to 1.5.5 (was 1.5.2) * upgrade sbt-scala-module to 3.0.0 (was 2.3.0) * upgrade Scala versions (2.12.15, 2.13.6, 3.0.2) * upgrade ScalaTest to 3.2.10 (was 3.2.9) * add JDK 17 to CI matrix * a few other minor cleanups
4957a71
to
31c24ac
Compare
and:
context is scala/scala-dev#785