Skip to content

add GitHub Actions, drop Travis-CI #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 28, 2021
Merged

add GitHub Actions, drop Travis-CI #193

merged 6 commits into from
Sep 28, 2021

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Aug 31, 2021

@SethTisue SethTisue marked this pull request as ready for review August 31, 2021 17:23
@SethTisue SethTisue requested review from julienrf and lrytz August 31, 2021 17:23
@SethTisue SethTisue marked this pull request as draft August 31, 2021 20:20
@SethTisue SethTisue marked this pull request as ready for review August 31, 2021 22:07
@SethTisue
Copy link
Member Author

leaving as draft for now until I've tried publishing from at least one of the other module repos I'm doing

@SethTisue SethTisue marked this pull request as draft September 1, 2021 13:07
@SethTisue SethTisue marked this pull request as ready for review September 9, 2021 22:09
@SethTisue
Copy link
Member Author

[error] Incompatibilities with dependencies of scala-parallel-collections:1.0.3
[error]   org.scala-lang:scala3-library_3: incompatible version change from 3.0.0 to 3.0.2 (compatibility: package versioning policy)

this was happening even before I threw in the 3.0.1->3.0.2 upgrade

it is reproducible locally with ++3.0.2 followed by core/versionPolicyReportDependencyIssues

@julienrf is this one you've seen before, is it obvious to you how to handle this? note that it's complaining about scala3-library_3 itself

@julienrf
Copy link
Contributor

is it obvious to you how to handle this? note that it's complaining about scala3-library_3 itself

scala3-library does not seem to declare a versionScheme, so sbt assumes “package versioning policy” by default. We can set the versionScheme ourselves here by adding this to the build (e.g., in commonSettings):

libraryDependencySchemes += "org.scala-lang" %% "scala3-library" % "semver-spec"

@SethTisue SethTisue self-assigned this Sep 10, 2021
@SethTisue
Copy link
Member Author

leaving as draft for now until I've tried publishing from at least one of the other module repos I'm doing

scala/scala-parser-combinators#418 finally made it over the finish line

@SethTisue SethTisue merged commit 351df2c into main Sep 28, 2021
@SethTisue SethTisue deleted the plugin-3.0 branch September 28, 2021 22:33
@SethTisue SethTisue mentioned this pull request Sep 28, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants