Skip to content

Add blog about Tasty Reader #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 17, 2020

Conversation

bishabosha
Copy link
Member

No description provided.

@bishabosha bishabosha force-pushed the blog/add-tasty-reader-blog branch from f8ff900 to 0cb14cd Compare October 13, 2020 15:09
@julienrf julienrf requested review from lrytz and SethTisue October 13, 2020 15:32
Copy link
Member

@SethTisue SethTisue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main body of the post is good. It is already publishable.

But, I do suggest that the intro aim at including all of the important information in brief, so that someone will get the essential points they need even if they don't go on and read the whole thing. Condense the entire blog post into a single page; begin with just that page; and then follow it with the more detailed version.

An example of an important piece of information that isn't revealed until quite late in the blog post is that only some Scala 3 features are consumable from Scala 2.

@SethTisue
Copy link
Member

Oh, one more thing. 2.13.14 comes out in just a couple weeks. Up to you, but I think you might want to wait until 2.13.4 is actually out, then you won't need to include the information about using a 2.13.14 nightly.

@bishabosha
Copy link
Member Author

bishabosha commented Nov 2, 2020

I've added more at the start, theres more of a problem with the library dependencies section due to there being no libraries currently for Scala 3.0.0-M1, perhaps that section should be redesigned in some way

@bishabosha bishabosha force-pushed the blog/add-tasty-reader-blog branch from f9da0a6 to c8d5bc2 Compare November 3, 2020 12:58
@bishabosha
Copy link
Member Author

added more to the overview section, and removed the mentions of snapshot scala versions

@SethTisue
Copy link
Member

intro LGTM now 👍

I wonder if you want to say a few words about the status of -Ytasty-reader and/or about the overall status of the feature in terms of experimental vs. non-experimental, is requiring the flag considered temporary, that kind of thing.

I was a bit surprised to see sourcecode among the dependencies. Isn't it a macro, so isn't it surprising that it would work?

@bishabosha
Copy link
Member Author

I wonder if you want to say a few words about the status of -Ytasty-reader and/or about the overall status of the feature in terms of experimental vs. non-experimental, is requiring the flag considered temporary, that kind of thing.

Thats a good point, I should update to mention this.

I was a bit surprised to see sourcecode among the dependencies. Isn't it a macro, so isn't it surprising that it would work?

Yes perhaps I should use a fictional library - tasty reader is lazy enough to only error when the code directly requires something unsupported - so a test suite that requires sourcecode.Position will fail

@bishabosha
Copy link
Member Author

I've changed the blog to use ScalaCheck now that it has released for Scala 3.0.0-M1, and I've added a section to talk about the Ytasty-reader flag

@bishabosha
Copy link
Member Author

updated the date for Friday the 13th

@SethTisue
Copy link
Member

We've had to push 2.13.4 out a bit again, as a few issues/PRs are still in flight, and then we'll need to float an "RC" (a designated nightly) and run the community build. Current target date is Mon Nov 16

@bishabosha
Copy link
Member Author

@SethTisue when is the proposed date now?

@darjutak darjutak merged commit 6582332 into scala:master Nov 17, 2020
SethTisue added a commit to SethTisue/scala-lang that referenced this pull request Nov 17, 2020
…-reader-blog"

This reverts commit 6582332, reversing
changes made to 09e7f2f.
@SethTisue
Copy link
Member

reverting until 2.13.4 has been published: #1179

SethTisue added a commit that referenced this pull request Nov 17, 2020
Revert "Merge pull request #1165 from scalacenter/blog/add-tasty-reader-blog"
@SethTisue
Copy link
Member

draft PR to re-add when the time comes: #1180

@sjrd sjrd deleted the blog/add-tasty-reader-blog branch November 17, 2020 15:56
@SethTisue
Copy link
Member

SethTisue commented Nov 17, 2020

when is the proposed date now?

@bishabosha 2.13.4-bin-74cffdd is our release candidate. if all goes well, we'll republish it as 2.13.4 on Thursday. let us know if you'd like any changes to the tasty-reader parts of https://github.com/scala/scala-dev/blob/scala-dev/releases/2.13.4.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants