Skip to content

Conversation

soc
Copy link
Contributor

@soc soc commented Jan 7, 2014

This is just the first half (removal of Manifests).
Let's hope someone with more in-depth knowledge of Tags will add
the second part (addition of Tags) in the future.

But anyway, no reason why we should let this rot any further.

This is just the first half (removal of Manifests).
Let's hope someone with more in-depth knowledge of Tags will add
the second part (addition of Tags) in the future.

But anyway, no reason why we should let this rot any further.
@xeno-by
Copy link

xeno-by commented Jan 7, 2014

This PR might be a bit premature, as scala-reflect isn't non-experimental yet.

@soc
Copy link
Contributor Author

soc commented Jan 7, 2014

I think the compiler can be more liberal in what it accepts compared to the spec, but I think it is not necessary to keep more or less obsolete things on life-support in the spec (where "life-support" means "doctors have abandoned the hospital 5 years ago and threw away the keys").

Given the usual speed at which spec PRs are handled, this commit will probably merged right in time with Scala 2.13.

@odersky
Copy link
Contributor

odersky commented Feb 5, 2014

I think the status of manifests vs tags is still a bit unclear. I would prefer we leave it until TypeTags have become non-experiemental

@adriaanm adriaanm added this to the 2.12 milestone Feb 5, 2014
@adriaanm adriaanm closed this Mar 10, 2014
@adriaanm adriaanm reopened this Mar 10, 2014
@adriaanm
Copy link
Contributor

assigned for milestone 2.12

@adriaanm adriaanm added the spec label Mar 10, 2014
liancheng pushed a commit to liancheng/scala-dist that referenced this pull request Jul 20, 2014
A little revise for the document
@adriaanm
Copy link
Contributor

adriaanm commented Dec 5, 2014

Please reopen on scala/scala when the time comes.

@adriaanm adriaanm closed this Dec 5, 2014
@SethTisue
Copy link
Member

@soc interested in picking this back up?

@soc
Copy link
Contributor Author

soc commented Aug 11, 2016

@SethTisue I'm not sure whether I have already removed this in my fork of the spec.

@soc
Copy link
Contributor Author

soc commented Aug 11, 2016

Just had a look, it's still there, but I think my change wouldn't be useful to you as it's not even in this repo anymore. I migrated all documentation into one repo back in 2015. (Wouldn't it make more sense to reword it in terms of ClassTags anyway instead of removing it?

@SethTisue
Copy link
Member

SethTisue commented Aug 11, 2016

I wasn't expressing an opinion about what the best fix was, just hoping someone fixes it somehow.

As for the which-repo issue, even if you're not interesting in submitting a PR yourself in the correct repo, a link to your proposed changes, for someone else to use as a basis for a PR in our repo if they choose, would be of nonzero helpfulness.

@soc
Copy link
Contributor Author

soc commented Aug 11, 2016

Sorry, if it was worded confusingly. I haven't removed it in my version, the rest was based on the hypothetical assumption that such a change existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants