Skip to content

SI-7629 Remove view bounds from spec #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

SI-7629 Remove view bounds from spec #118

wants to merge 1 commit into from

Conversation

soc
Copy link
Contributor

@soc soc commented Jan 7, 2014

No description provided.

@retronym
Copy link
Member

retronym commented Jan 7, 2014

These are still in the language, seems to soon to unspec them.

@soc
Copy link
Contributor Author

soc commented Jan 7, 2014

The compiler is a superset of the things specified in the spec, I think it is perfectly fine if the compiler keeps supporting things which are deprecated, but I don't think we should burden the actual spec with deprecations.

@soc
Copy link
Contributor Author

soc commented Jan 7, 2014

@retronym Anyway, given the usual speed at which spec PRs are handled, this commit will probably merged right in time with Scala 2.13.

@retronym
Copy link
Member

retronym commented Jan 7, 2014

@odersky doesn't read github pings; you should mail him directly if you want review.

@odersky
Copy link
Contributor

odersky commented Feb 5, 2014

I concur with Jason. There's no point to change the spec if the compiler still supports it. They will be removed, but the right way to do it is to change everything in sync.

@adriaanm adriaanm closed this Feb 5, 2014
@adriaanm
Copy link
Contributor

adriaanm commented Feb 5, 2014

Once the spec is in the main repo and follows the branching structure, we can update it there.

@adriaanm adriaanm added this to the 2.12 milestone Feb 5, 2014
@adriaanm
Copy link
Contributor

adriaanm commented Feb 5, 2014

I've reopened and assigned to milestone 2.12

@adriaanm adriaanm reopened this Feb 5, 2014
@adriaanm adriaanm added the spec label Mar 10, 2014
liancheng pushed a commit to liancheng/scala-dist that referenced this pull request Jul 20, 2014
Reduce the memory footprint of BlockInfo objects

This pull request reduces the memory footprint of all BlockInfo objects and makes additional optimizations for shuffle blocks.  For all BlockInfo objects, these changes remove two boolean fields and one Object field.  For shuffle blocks, we additionally remove an Object field and a boolean field.

When storing tens of thousands of these objects, this may add up to significant memory savings.  A ShuffleBlockInfo now only needs to wrap a single long.

This was motivated by a [report of high blockInfo memory usage during shuffles](https://mail-archives.apache.org/mod_mbox/incubator-spark-user/201310.mbox/%3C20131026134353.202b2b9b%40sh9%3E).

I haven't run benchmarks to measure the exact memory savings.

/cc @aarondav
liancheng pushed a commit to liancheng/scala-dist that referenced this pull request Jul 20, 2014
liancheng pushed a commit to liancheng/scala-dist that referenced this pull request Jul 20, 2014
… "y...

...arn-cluster"

Author: Sandy Ryza <[email protected]>

Closes scala#118 from sryza/sandy-spark-1211 and squashes the following commits:

d4001c7 [Sandy Ryza] SPARK-1211. In ApplicationMaster, set spark.master system property to "yarn-cluster"
@adriaanm
Copy link
Contributor

adriaanm commented Dec 5, 2014

Please reopen on scala/scala when the time comes.

@adriaanm adriaanm closed this Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants