JLine 3: errors during tokenization are mishandled (in multiple ways)

[Jasper-M]

2.13.1

scala> import scala.language.experimental.macros
import scala.language.experimental.macros

scala> import scala.reflect.macros.blackbox.Context
import scala.reflect.macros.blackbox.Context

scala> def fooMacro(c: Context): c.Tree = {import c.universe._; q"42"}
fooMacro: (c: scala.reflect.macros.whitebox.Context)c.Tree

scala> def foo: Int = macro fooMacro
defined term macro foo: Int

scala> foo
res3: Int = 42

2.13.2-bin-8ee21e7

scala> def foo: Int = macro fooMacro
                            ^
       error: macro implementation reference has wrong shape. required:
       macro [<static object>].<method name>[[<type args>]] or
       macro [<macro bundle>].<method name>[[<type args>]]
       note: macro definition is not supported in the REPL when using -Yrepl-classbased.

2.13.2-bin-bc1cad4

scala> def foo: Int = macro fooMacro                      ^
       error: macro is now a reserved word; usage as an identifier is disallowed

[dwijnand]

The "macros don't work in class-based REPL" part is expected. But the other part looks like a regression to me. Thanks, @Jasper-M.

[Jasper-M]

It's expected (if you know about it) but unfortunate. Was this considered when deciding on -Yrepl-classbased by default?

[dwijnand]

Yes. The upsides of the class-based implementation was considered greater than the upsides of being able to define macros in the REPL with the default choice. You can use -Yrepl-class-based:false to opt-back.

[Jasper-M]

Ok I surrender to Lightbend support. Then I guess this issue is only about JLine 3 after all.

[som-snytt]

Me too. I never use macros but had to try something out.

[dwijnand]

Should I add to the error message a mention to -Yrepl-class-based:false?

[Jasper-M]

Should I add to the error message a mention to -Yrepl-class-based:false?

Yes sounds good. I was in half a mind to send a PR myself if I would find some time.

[dwijnand]

scala/scala#8844 (this is the side issue, the main JLine 3 issue still needs attention.)