Skip to content

replace Travis-CI with GitHub Actions #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

Conversation

SethTisue
Copy link
Member

@SethTisue SethTisue commented Oct 1, 2021

@SethTisue
Copy link
Member Author

SethTisue commented Oct 1, 2021

this is still very WIPpy at the moment

this module has the weirdest build and CI setup of any of the modules, so it's going to take some extra thought and care

  • add publishing secrets to Actions settings
  • replace ci build command
  • adapt/replace TEST_SCALAFIX
  • adapt/replace TEST_BINARY_COMPAT
  • adapt/replace TEST_SCALAFMT and the scalafmt-test and scalafmt build commands
    • admin directory had install-scalafmt-githook.sh and pre-commit and scalafmt.sh but I really don't want all that, surely we can do it some simpler way?
  • I downgraded to scalafix 0.9.30 for now because with 0.9.31 it hit some 2.12.14 vs 2.12.15 thing I didn't understand or dig into yet
  • I further downgraded to scalafix 0.9.29 for now because scalafix-tests failed and I don't know why

@SethTisue SethTisue closed this Oct 5, 2021
@SethTisue
Copy link
Member Author

SethTisue commented Oct 5, 2021

well, this got out of hand.

resubmitting some of this stuff at #486, while still staying on Travis-CI

then we can switch CI systems in another followup PR

@SethTisue
Copy link
Member Author

note that the problems I thought I was having with the scalafix version were actually because because setting excludeFilter to make headerCheck pass was breaking scalafixTests. in #487 I'm skipping headerCheck when it's unwanted with headerCheck := Nil instead

@SethTisue SethTisue deleted the bye-bye-travis-ci branch October 5, 2021 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant