Skip to content

Added scala annotation for code segments to SIP #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Conversation

soronpo
Copy link
Contributor

@soronpo soronpo commented Feb 13, 2017

No description provided.

@soronpo
Copy link
Contributor Author

soronpo commented Feb 13, 2017

@jvican Please merge so I can see if this resolved the problem.

@SethTisue
Copy link
Member

Please merge so I can see if this resolved the problem

are you unable to build the site locally? (or is this an issue where the local rendering and the rendering on the site differ somehow...?)

@jvican
Copy link
Member

jvican commented Feb 13, 2017

FTR @soronpo, you can build the site yourself. Check the README 😉.

Merging since everything is green. And hell yeah, I love green.

@jvican jvican merged commit 72b355f into scala:master Feb 13, 2017
@soronpo
Copy link
Contributor Author

soronpo commented Feb 13, 2017

You guys are right. Unfortunately, I'm currently having local build issues. Now that I rechecked the file on the site and see it's still bad (or even worse), I conclude I must fix my build issues and check things locally.

@soronpo
Copy link
Contributor Author

soronpo commented Feb 13, 2017

I recommend that you add this as a requirement for the GitHub SIP PR review process, by requesting each proposal will be viewed locally by the PR submitter and he/she would confirm that everything is OK. I assumed that if it looks OK as MD, it will look OK on the site. This is evidently wrong 😞

@jvican
Copy link
Member

jvican commented Feb 13, 2017

I would consider adding that to the rules and the process, thanks for the suggestion @soronpo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants