Skip to content

Conversation

@mpociecha
Copy link
Contributor

Other than that there are a few changes related to wording etc.

@mpociecha
Copy link
Contributor Author

@adamwy Could you take a look?

@jvican
Copy link
Member

jvican commented Feb 13, 2017

Can you please rebase on top of #685?

@mpociecha
Copy link
Contributor Author

mpociecha commented Feb 13, 2017

Okay, I'll do this in the evening (yes - I know it will take a minute, but I can't right now). :)

@jvican
Copy link
Member

jvican commented Feb 13, 2017

Thanks @mpociecha, there's no rush 😉.

Other than that there are a few changes related to wording etc.
@mpociecha mpociecha force-pushed the improve-pl-translation branch from 99bab54 to 3c14f0f Compare February 13, 2017 17:06
@mpociecha
Copy link
Contributor Author

@Krever Maybe could you take a look? :)

Copy link

@Krever Krever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job :) I've browsed through changes and found nothing bad, but I have to say that I really suck at punctuation.

@charafau
Copy link
Contributor

I also scanned the PR. Looks good but I also suck at punctuation. Thanks!

@jvican
Copy link
Member

jvican commented Feb 14, 2017

@Krever @charafau Thank you very much for your reviews guys 😄.

Should we go ahead and merge @heathermiller?

Copy link
Contributor

@adam-wyluda adam-wyluda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Great job and thank you for these improvements @mpociecha!

@heathermiller
Copy link
Member

🎉🎉 Woohoo!! 🎉🎉 Thank you everybody for your reviews! And of course, thank you @mpociecha for these improvements! 😄

@heathermiller heathermiller merged commit aa9ba77 into scala:master Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants