Skip to content

Fix compiler options #1442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 18, 2019
Merged

Fix compiler options #1442

merged 2 commits into from
Jul 18, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented Jul 18, 2019 •
edited
Loading

Scala compiler options for 2.13 added in #1435 is broken.
Unfortunately, CI (Drone) did not run properly in the PR somehow, so gave false-success and accidentally merged.

This PR fixes

  • Wrong indentation in choices properties.
  • Some unescaped chars \u and " in string

I then fix generateDocsData command in scala/scala repository to reflect these changes.

@SethTisue SethTisue merged commit 8625f61 into scala:master Jul 18, 2019
@exoego exoego mentioned this pull request Jul 18, 2019
Merged
@exoego exoego deleted the fix-compiler-options branch July 18, 2019 22:54
@exoego
Copy link
Contributor Author

exoego commented Jul 18, 2019

Opened a bugfix PR in scala/scala#8247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exoego @SethTisue