add sbt 1.0 and zinc (as a project in the build) #581

SethTisue · 2017-08-01T22:07:58Z

fixes #264

SethTisue · 2017-08-01T22:11:49Z

results from local testing of this first stab:

[sbt] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[sbt] [warn] 	::          UNRESOLVED DEPENDENCIES         ::
[sbt] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::
[sbt] [warn] 	:: com.typesafe#sbt-mima-plugin;0.1.17: not found
[sbt] [warn] 	:: org.foundweekends#sbt-bintray;0.5.1: not found
[sbt] [warn] 	:: org.scala-sbt#sbt-contraband;0.3.0: not found
[sbt] [warn] 	:: com.jsuereth#sbt-pgp;1.1.0-M1: not found
[sbt] [warn] 	:: com.typesafe.dbuild#plugin;0.9.7: not found
[sbt] [warn] 	::::::::::::::::::::::::::::::::::::::::::::::

I imagine the issue is that sbt 1.0 is now built with sbt 1.0, but the community build is still on 0.13.16. so I guess #552 is a prerequisite for this

dwijnand · 2017-08-02T08:39:45Z

configs/project-refs.conf

+  sbt-uri:                      "https://github.com/sbt/sbt.git#1.0.0"
+  sbt-io-uri:                   "https://github.com/sbt/io.git#v1.0.0-M11"
+  sbt-librarymanagement-uri:    "https://github.com/sbt/librarymanagement.git#v1.0.0-X15"
+  sbt-util-uri:                 "https://github.com/sbt/util.git#v1.0.0-M24"


Thanks Seth, after the unrelated breakage in lightbend-labs/mima#191 I was thinking about how our cross-repo source/binary breakages in sbt are over so we should get our code building with everything else. (and then I forgot to do anything about it)

The possible targets for compilation are either:

the latest tags (RC3 across the board, rather than the misc X??/M?? tags)

the temporary 1.0.0 release branches, where the latest RC fixes are being merged, in prep for the v1.0.0 releases, then will be merged into 1.x and deleted

the 1.x branches

Personally I'd track 1.0.0, and then switch when we delete them - I'll try and remember to PR or at least ping you.

WRT dbuild, work is progressing I see in lightbend-labs/dbuild#198, but @cunei's on a well deserved break atm.

this is blocked on sbt 1.0 support in dbuild, so considering it on hold for now.

but, I will separately try to add zinc, just by itself.

@SethTisue dbuild 0.9.9 is out, with support for sbt 1.0.0 final.

SethTisue · 2017-08-07T19:41:44Z

never mind about adding zinc separately, it depends on sbt modules, so this will all need to happen together

SethTisue · 2017-08-10T22:35:46Z

dbuild bump is #585

SethTisue · 2017-08-10T23:10:56Z

@dwijnand what do you make of this?

[zinc] [error] java.lang.AbstractMethodError: Method sbtprotoc/ProtocPlugin$.sjsonnew$CalendarFormats$_setter_$offsetDateTimeStringIso_$eq(Lsjsonnew/IsoString;)V is abstract
[zinc] [error] 	at sbtprotoc.ProtocPlugin$.sjsonnew$CalendarFormats$_setter_$offsetDateTimeStringIso_$eq(ProtocPlugin.scala)
[zinc] [error] 	at sjsonnew.CalendarFormats.$init$(CalendarFormats.scala:34)
[zinc] [error] 	at sbtprotoc.ProtocPlugin$.<init>(ProtocPlugin.scala:11)
[zinc] [error] 	at sbtprotoc.ProtocPlugin$.<clinit>(ProtocPlugin.scala)
[zinc] [error] 	at java.lang.Class.forName0(Native Method)
[zinc] [error] 	at java.lang.Class.forName(Class.java:348)
[zinc] [error] 	at sbt.internal.inc.ModuleUtilities$.getObject(ModuleUtilities.scala:20)
[zinc] [error] 	at sbt.internal.inc.ModuleUtilities$.getCheckedObject(ModuleUtilities.scala:27)
[zinc] [error] 	at sbt.internal.inc.ModuleUtilities$.$anonfun$getCheckedObjects$1(ModuleUtilities.scala:31)
[zinc] [error] 	at scala.collection.immutable.Stream.$anonfun$map$1(Stream.scala:415)
[zinc] [error] 	at scala.collection.immutable.Stream$Cons.tail(Stream.scala:1169)
[zinc] [error] 	at scala.collection.immutable.Stream$Cons.tail(Stream.scala:1159)
[zinc] [error] 	at scala.collection.generic.Growable.loop$1(Growable.scala:54)
[zinc] [error] 	at scala.collection.generic.Growable.$plus$plus$eq(Growable.scala:58)
[zinc] [error] 	at scala.collection.generic.Growable.$plus$plus$eq$(Growable.scala:50)
[zinc] [error] 	at scala.collection.mutable.ListBuffer.$plus$plus$eq(ListBuffer.scala:186)
[zinc] [error] 	at scala.collection.mutable.ListBuffer.$plus$plus$eq(ListBuffer.scala:44)
[zinc] [error] 	at scala.collection.TraversableLike.$plus$plus(TraversableLike.scala:147)
[zinc] [error] 	at scala.collection.TraversableLike.$plus$plus$(TraversableLike.scala:143)
[zinc] [error] 	at scala.collection.immutable.List.$plus$plus(List.scala:207)
[zinc] [error] 	at sbt.internal.PluginDiscovery$.discoverAll(PluginDiscovery.scala:47)
[zinc] [error] 	at sbt.internal.Load$.loadPlugins(Load.scala:1260)
[zinc] [error] 	at sbt.internal.Load$.loadPluginDefinition(Load.scala:1205)
[zinc] [error] 	at sbt.internal.Load$.buildPlugins(Load.scala:1184)
[zinc] [error] 	at sbt.internal.Load$.plugins(Load.scala:1167)
[zinc] [error] 	at sbt.internal.Load$.$anonfun$loadUnit$2(Load.scala:679)
[zinc] [error] 	at sbt.internal.Load$.timed(Load.scala:1336)
[zinc] [error] 	at sbt.internal.Load$.$anonfun$loadUnit$1(Load.scala:679)
[zinc] [error] 	at sbt.internal.Load$.timed(Load.scala:1336)
[zinc] [error] 	at sbt.internal.Load$.loadUnit(Load.scala:673)
[zinc] [error] 	at sbt.internal.Load$.$anonfun$builtinLoader$4(Load.scala:477)
[zinc] [error] 	at sbt.internal.BuildLoader$.$anonfun$componentLoader$5(BuildLoader.scala:154)
[zinc] [error] 	at sbt.internal.BuildLoader.apply(BuildLoader.scala:219)
[zinc] [error] 	at sbt.internal.Load$.loadURI$1(Load.scala:539)
[zinc] [error] 	at sbt.internal.Load$.loadAll(Load.scala:555)
[zinc] [error] 	at sbt.internal.Load$.loadURI(Load.scala:485)
[zinc] [error] 	at sbt.internal.Load$.load(Load.scala:464)
[zinc] [error] 	at sbt.internal.Load$.$anonfun$apply$1(Load.scala:249)
[zinc] [error] 	at sbt.internal.Load$.timed(Load.scala:1336)
[zinc] [error] 	at sbt.internal.Load$.apply(Load.scala:249)
[zinc] [error] 	at sbt.internal.Load$.defaultLoad(Load.scala:65)
[zinc] [error] 	at sbt.BuiltinCommands$.liftedTree1$1(Main.scala:695)
[zinc] [error] 	at sbt.BuiltinCommands$.doLoadProject(Main.scala:695)
[zinc] [error] 	at sbt.BuiltinCommands$.$anonfun$loadProjectImpl$2(Main.scala:687)
[zinc] [error] 	at sbt.Command$.$anonfun$applyEffect$4(Command.scala:125)
[zinc] [error] 	at sbt.Command$.$anonfun$applyEffect$2(Command.scala:121)
[zinc] [error] 	at sbt.MainLoop$.processCommand(MainLoop.scala:121)
[zinc] [error] 	at sbt.MainLoop$.$anonfun$next$2(MainLoop.scala:105)
[zinc] [error] 	at sbt.State$$anon$1.runCmd$1(State.scala:228)
[zinc] [error] 	at sbt.State$$anon$1.process(State.scala:234)
[zinc] [error] 	at sbt.MainLoop$.$anonfun$next$1(MainLoop.scala:105)
[zinc] [error] 	at sbt.internal.util.ErrorHandling$.wideConvert(ErrorHandling.scala:17)
[zinc] [error] 	at sbt.MainLoop$.next(MainLoop.scala:105)
[zinc] [error] 	at sbt.MainLoop$.run(MainLoop.scala:98)
[zinc] [error] 	at sbt.MainLoop$.$anonfun$runWithNewLog$1(MainLoop.scala:76)
[zinc] [error] 	at sbt.io.Using.apply(Using.scala:23)
[zinc] [error] 	at sbt.MainLoop$.runWithNewLog(MainLoop.scala:70)
[zinc] [error] 	at sbt.MainLoop$.runAndClearLast(MainLoop.scala:52)
[zinc] [error] 	at sbt.MainLoop$.runLoggedLoop(MainLoop.scala:37)
[zinc] [error] 	at sbt.MainLoop$.runLogged(MainLoop.scala:29)
[zinc] [error] 	at sbt.StandardMain$.runManaged(Main.scala:104)
[zinc] [error] 	at sbt.xMain.run(Main.scala:71)
[zinc] [error] 	at xsbt.boot.Launch$$anonfun$run$1.apply(Launch.scala:109)
[zinc] [error] 	at xsbt.boot.Launch$.withContextLoader(Launch.scala:128)
[zinc] [error] 	at xsbt.boot.Launch$.run(Launch.scala:109)
[zinc] [error] 	at xsbt.boot.Launch$$anonfun$apply$1.apply(Launch.scala:35)
[zinc] [error] 	at xsbt.boot.Launch$.launch(Launch.scala:117)
[zinc] [error] 	at xsbt.boot.Launch$.apply(Launch.scala:18)
[zinc] [error] 	at xsbt.boot.Boot$.runImpl(Boot.scala:41)
[zinc] [error] 	at xsbt.boot.Boot$.main(Boot.scala:17)
[zinc] [error] 	at xsbt.boot.Boot.main(Boot.scala)

dwijnand · 2017-08-11T07:26:22Z

thesamet/sbt-protoc#32

Yoshida-san has already fixed it in thesamet/sbt-protoc#33 and it just got released. So I'll finish upgrading zinc's build in sbt/zinc#385 and once merged this should unblock.

SethTisue · 2017-08-12T03:36:02Z

I made some very good progress on this today:

[info] Project gigahorse---------------: SUCCESS (unchanged, not rebuilt)
[info] Project sbt-io------------------: SUCCESS (unchanged, not rebuilt)
[info] Project sbt-librarymanagement---: SUCCESS (project rebuilt ok)
[info] Project sbt-util----------------: SUCCESS (project rebuilt ok)
[info] Project shaded-scalajson--------: SUCCESS (unchanged, not rebuilt)
[info] Project sjson-new---------------: SUCCESS (unchanged, not rebuilt)

SethTisue · 2017-08-12T03:38:02Z

but as seen at https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1782/consoleFull I am currently getting:

[zinc] [info] *** 3 TESTS FAILED ***
[zinc] [error] Failed: Total 3, Failed 3, Errors 0, Passed 0
[zinc] [error] Failed tests:
[zinc] [error] 	sbt.internal.inc.ZincComponentCompilerSpec

@dwijnand @eed3si9n @jvican any insight into what's going on here?

SethTisue · 2017-08-12T03:54:45Z

(I can work around it by just not running the zinc tests, but of course it would be better if we could run them)

fixes scala#264

SethTisue · 2017-08-12T14:01:43Z

fyi @cunei (sbt 1.0.0 in dbuild 0.9.9 working fine)
fyi @dwijnand @eed3si9n @jvican

anyone interested in addressing this?

+    name: "sbt"
+    // some test code fails to compile, a specs2 version thing I think
+    extra.run-tests: false

dwijnand · 2017-08-14T08:46:32Z

Deviating from the norm, zinc's tests require things to be locally published, so they can be retrieved while testing. This trips up dbuild, so that test won't pass.

I think we should look at ways to make those tests opt-out-able (test tags or something?) so we can run our suite against the nightly compilers.

SethTisue mentioned this pull request Aug 1, 2017

add new sbt+zinc, remove old sbt+zinc #264

Closed

SethTisue added the on hold label Aug 1, 2017

dwijnand reviewed Aug 2, 2017

View reviewed changes

SethTisue changed the title ~~add sbt and zinc~~ add sbt 1.0 (as a project in the build) Aug 6, 2017

SethTisue changed the title ~~add sbt 1.0 (as a project in the build)~~ add sbt 1.0 and zinc (as a project in the build) Aug 7, 2017

SethTisue removed the on hold label Aug 10, 2017

SethTisue self-assigned this Aug 10, 2017

SethTisue mentioned this pull request Aug 11, 2017

Upgrade to sbt 1.0.0-RC3 sbt/zinc#385

Closed

SethTisue force-pushed the add-sbt-1.0 branch 4 times, most recently from cc1b4aa to 583c968 Compare August 12, 2017 02:49

SethTisue force-pushed the add-sbt-1.0 branch from 10725b1 to 7190da7 Compare August 12, 2017 03:42

add sbt + zinc (+ gigahorse + sjson-new)

56dfbee

fixes scala#264

SethTisue force-pushed the add-sbt-1.0 branch from fbbd6ee to 56dfbee Compare August 12, 2017 13:59

SethTisue merged commit 4d26127 into scala:2.12.x Aug 12, 2017

SethTisue deleted the add-sbt-1.0 branch August 12, 2017 14:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add sbt 1.0 and zinc (as a project in the build) #581

add sbt 1.0 and zinc (as a project in the build) #581

Uh oh!

SethTisue commented Aug 1, 2017

Uh oh!

SethTisue commented Aug 1, 2017

Uh oh!

dwijnand Aug 2, 2017

Uh oh!

SethTisue Aug 6, 2017 •

edited

Loading

Uh oh!

cunei Aug 10, 2017

Uh oh!

SethTisue commented Aug 7, 2017

Uh oh!

SethTisue commented Aug 10, 2017

Uh oh!

SethTisue commented Aug 10, 2017

Uh oh!

dwijnand commented Aug 11, 2017

Uh oh!

SethTisue commented Aug 12, 2017

Uh oh!

SethTisue commented Aug 12, 2017 •

edited

Loading

Uh oh!

SethTisue commented Aug 12, 2017

Uh oh!

SethTisue commented Aug 12, 2017

Uh oh!

dwijnand commented Aug 14, 2017

Uh oh!

Uh oh!

add sbt 1.0 and zinc (as a project in the build) #581

add sbt 1.0 and zinc (as a project in the build) #581

Uh oh!

Conversation

SethTisue commented Aug 1, 2017

Uh oh!

SethTisue commented Aug 1, 2017

Uh oh!

dwijnand Aug 2, 2017

Choose a reason for hiding this comment

Uh oh!

SethTisue Aug 6, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cunei Aug 10, 2017

Choose a reason for hiding this comment

Uh oh!

SethTisue commented Aug 7, 2017

Uh oh!

SethTisue commented Aug 10, 2017

Uh oh!

SethTisue commented Aug 10, 2017

Uh oh!

dwijnand commented Aug 11, 2017

Uh oh!

SethTisue commented Aug 12, 2017

Uh oh!

SethTisue commented Aug 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SethTisue commented Aug 12, 2017

Uh oh!

SethTisue commented Aug 12, 2017

Uh oh!

dwijnand commented Aug 14, 2017

Uh oh!

Uh oh!

SethTisue Aug 6, 2017 •

edited

Loading

SethTisue commented Aug 12, 2017 •

edited

Loading