Skip to content

add new sbt+zinc, remove old sbt+zinc #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Aug 30, 2016 · 8 comments · Fixed by #581
Closed

add new sbt+zinc, remove old sbt+zinc #264

SethTisue opened this issue Aug 30, 2016 · 8 comments · Fixed by #581

Comments

@SethTisue
Copy link
Member

typesafehub/zinc is obsolete and we don't need to be building it anymore

and we should be building sbt/zinc, where the action is these days

@SethTisue SethTisue self-assigned this Aug 30, 2016
@dwijnand
Copy link
Member

I'm going to be working on several aspects from the modules splitting of sbt, so I can do this.

@dwijnand
Copy link
Member

sbt/zinc depends on a number of dependencies including more sbt modules.

We intend to setup a dbuild for sbt modules (and later plugins) for the purpose ensuring that the latest sbt continues to work (as opposed to the community build which is ensuring the libraries continue to work with changes to Scala).

Once we have that we can start more aggressively making changes across modules in preparation for sbt 1.0, but that might leave moments of cross-module breakages.

As such we wouldn't want to the community build to suffer, so this issue might be open for a while..

@SethTisue
Copy link
Member Author

SethTisue commented Sep 21, 2016

we also discussed this at #290. summary: tracking sbt 1.0 master is too fragile for now, because of module interdependencies, but we could build from a tag, and then try to remember to push that tag forward from time to time

in particular, it sounds like we can go ahead and add sbt/sbt.git#v1.0.0-M4, along with its modules including sbt/zinc — the tags for the individual modules can be determined by looking at the version numbers in sbt's project/Dependencies.scala

@SethTisue SethTisue assigned SethTisue and unassigned SethTisue Sep 21, 2016
@SethTisue SethTisue changed the title add new zinc, remove old zinc add new sbt+zinc, remove old sbt+zinc Sep 21, 2016
@SethTisue
Copy link
Member Author

SethTisue commented Sep 24, 2016

@dwijnand what do you make of these errors:

[sbt:error] /home/jenkins/workspace/scala-2.12.x-integrate-community-build/target-0.9.5/extraction/3a1c6f7c2f41d83a27331e50e2b378fbc10a8dff/projects/693975c068ddfe9dc96e007c24e9a8b2b41ed1f8/build.sbt:41: error: value bintrayRepo is not a member of object sbt.Resolver
[sbt:error]   resolvers += Resolver.bintrayRepo("sbt", "maven-releases"),
[sbt:error]                         ^

at https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/629/consoleFull ?

the changes I was testing are SethTisue@93f4fe2

it seems like dbuild must be using an old sbt somehow, but I've checked carefully that we're specifying 0.13.12 everywhere, and I see no other evidence in the log that an older version is being used

@dwijnand
Copy link
Member

It's the very confusing sbt/sbt#1696 which I'm sure you've found.

Haven't looked into why or how it's happening.

@SethTisue
Copy link
Member Author

which I'm sure you've found

yeah I couldn't tell if it was a real issue or just people confused about what version they're running

SethTisue added a commit to SethTisue/community-build that referenced this issue Oct 4, 2016
there's no great benefit to compiling such an old version of sbt
on such a new version of Scala, and it's fragile.  we'll re-add
sbt its modules (including the new zinc) when the time comes;
it's scala#264
SethTisue added a commit to SethTisue/community-build that referenced this issue Oct 4, 2016
there's no great benefit to compiling such an old version of sbt
on such a new version of Scala, and it's fragile.  we'll re-add
sbt its modules (including the new zinc) when the time comes;
it's scala#264
SethTisue added a commit to SethTisue/community-build that referenced this issue Oct 4, 2016
much of which was commented out anyway

there's no great benefit to compiling such an old version of sbt on
such a new version of Scala, and doing so is fragile.  fear not, we'll
re-add sbt and its modules (including the new zinc) when the time
comes; it's scala#264
SethTisue added a commit to SethTisue/community-build that referenced this issue Oct 4, 2016
much of which was commented out anyway

there's no great benefit to compiling such an old version of sbt on
such a new version of Scala, and doing so is fragile.  fear not, we'll
re-add sbt and its modules (including the new zinc) when the time
comes; it's scala#264
@SethTisue SethTisue removed their assignment Oct 26, 2016
@SethTisue SethTisue mentioned this issue Feb 24, 2017
@SethTisue
Copy link
Member Author

SethTisue commented Apr 7, 2017

sbt 1.0 is now a lot closer to being a reality, so it's time or almost time to proceed with this. I asked @dwijnand about it just now and he agreed. as we already said earlier, it will probably be necessary to use tags rather than track branches.

SethTisue added a commit to SethTisue/community-build that referenced this issue Aug 1, 2017
@SethTisue
Copy link
Member Author

PR: #581. interested parties please subscribe

SethTisue added a commit to SethTisue/community-build that referenced this issue Aug 12, 2017
SethTisue added a commit to SethTisue/community-build that referenced this issue Aug 12, 2017
SethTisue added a commit to SethTisue/community-build that referenced this issue Aug 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants