Skip to content

add conductr-lib back to the 2.12 build #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Jul 11, 2017 · 4 comments
Closed

add conductr-lib back to the 2.12 build #573

SethTisue opened this issue Jul 11, 2017 · 4 comments
Assignees

Comments

@SethTisue
Copy link
Member

provisionally removed by @retronym during the push for 2.12.3

previously: #570, #571

@SethTisue SethTisue self-assigned this Jul 11, 2017
@SethTisue
Copy link
Member Author

from Slack:

we had a quick look at this today, pinned an older version of conductr-lib that didn't yet have the projects listed in your recent patch in the community build config
so going back should be not too hard, if there's no quick fix to use the current version

@SethTisue
Copy link
Member Author

current dependency structure of conductr-lib

[conductr-lib] [info] akka24Common -> scalaCommon
[conductr-lib] [info] akka25Common -> scalaCommon
[conductr-lib] [info] akka24TestLib -> 
[conductr-lib] [info] play25ConductRBundleLib -> akka24ConductRBundleLib,play25Common,javaTestLib,akka24TestLib
[conductr-lib] [info] akka25TestLib -> 
[conductr-lib] [info] scalaConductRBundleLib -> conductRBundleLib,scalaCommon,akka24TestLib
[conductr-lib] [info] akka24ConductRClientLib -> scalaConductRClientLib,akka24Common,akka24TestLib
[conductr-lib] [info] lagom13JavaConductRBundleLib -> play25ConductRBundleLib,javaTestLib,akka24TestLib
[conductr-lib] [info] akka25ConductRClientLib -> scalaConductRClientLib,akka25Common,akka25TestLib
[conductr-lib] [info] play26ConductRClientLib -> scalaConductRClientLib,play26Common,javaTestLib,akka25TestLib
[conductr-lib] [info] play26ConductRBundleLib -> akka25ConductRBundleLib,play26Common,javaTestLib,akka25TestLib
[conductr-lib] [info] root -> 
[conductr-lib] [info] akka25ConductRBundleLib -> scalaConductRBundleLib,akka25Common,akka25TestLib
[conductr-lib] [info] conductRBundleLib -> common,akka24TestLib
[conductr-lib] [info] javaCommon -> common
[conductr-lib] [info] play25Common -> javaCommon,scalaCommon
[conductr-lib] [info] scalaConductRClientLib -> scalaCommon,akka24TestLib
[conductr-lib] [info] scalaCommon -> common
[conductr-lib] [info] lagom13ScalaConductRBundleLib -> play25ConductRBundleLib,javaTestLib,akka24TestLib
[conductr-lib] [info] common -> akka24TestLib
[conductr-lib] [info] play25ConductRClientLib -> scalaConductRClientLib,play25Common,javaTestLib,akka24TestLib
[conductr-lib] [info] play26Common -> javaCommon,scalaCommon
[conductr-lib] [info] javaTestLib -> 
[conductr-lib] [info] akka24ConductRBundleLib -> scalaConductRBundleLib,akka24Common,akka24TestLib
[conductr-lib] [info] javaConductRBundleLib -> conductRBundleLib,javaCommon,javaTestLib,akka24TestLib
[conductr-lib] [info] Aggregates of subprojects:
[conductr-lib] [info] akka24Common -> 
[conductr-lib] [info] akka25Common -> 
[conductr-lib] [info] akka24TestLib -> 
[conductr-lib] [info] play25ConductRBundleLib -> 
[conductr-lib] [info] akka25TestLib -> 
[conductr-lib] [info] scalaConductRBundleLib -> 
[conductr-lib] [info] akka24ConductRClientLib -> 
[conductr-lib] [info] lagom13JavaConductRBundleLib -> 
[conductr-lib] [info] akka25ConductRClientLib -> 
[conductr-lib] [info] play26ConductRClientLib -> 
[conductr-lib] [info] play26ConductRBundleLib -> 
[conductr-lib] [info] root -> akka24Common,akka25Common,akka24TestLib,play25ConductRBundleLib,akka25TestLib,scalaConductRBundleLib,akka24ConductRClientLib,lagom13JavaConductRBundleLib,akka25ConductRClientLib,play26ConductRClientLib,play26ConductRBundleLib,akka25ConductRBundleLib,conductRBundleLib,javaCommon,play25Common,scalaConductRClientLib,scalaCommon,lagom13ScalaConductRBundleLib,common,play25ConductRClientLib,play26Common,javaTestLib,akka24ConductRBundleLib,javaConductRBundleLib
[conductr-lib] [info] akka25ConductRBundleLib -> 
[conductr-lib] [info] conductRBundleLib -> 
[conductr-lib] [info] javaCommon -> 
[conductr-lib] [info] play25Common -> 
[conductr-lib] [info] scalaConductRClientLib -> 
[conductr-lib] [info] scalaCommon -> 
[conductr-lib] [info] lagom13ScalaConductRBundleLib -> 
[conductr-lib] [info] common -> 
[conductr-lib] [info] play25ConductRClientLib -> 
[conductr-lib] [info] play26Common -> 
[conductr-lib] [info] javaTestLib -> 
[conductr-lib] [info] akka24ConductRBundleLib -> 
[conductr-lib] [info] javaConductRBundleLib -> 

@SethTisue
Copy link
Member Author

SethTisue commented Jul 24, 2017

common -> akka24TestLib is what is leading to the failure

in community.dbuild, we have the Akka 2.4 subprojects of conductr-lib disabled because "not our Akka version" says a comment, but actually, the community build is on Akka 2.4 not 2.5, so that seems to be a mistake

@SethTisue
Copy link
Member Author

3922d2a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant