upgrade to sbt 0.13.16 + refresh MiMA + reinstate conductr-lib + add scalastyle + refresh lightbend-emoji

[SethTisue]

not to be merged until 0.13.16 final is out. in the meantime,
just helping test the new sbt version. @eed3si9n @dwijnand

[SethTisue]

test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1468/consoleFull

[dwijnand]

EXTRACTION FAILED (failed: scala-parser-combinators)

Cyclic reference involving
*:scalaVersion
root-950fabd31421f835198eabd03f5fa1753af44c91/*:crossScalaVersions
root-950fabd31421f835198eabd03f5fa1753af44c91/*:scalaVersion

@SethTisue known?

[SethTisue]

perhaps a recent change in that repo. I'll investigate

[lrytz]

[scala-parser-combinators] Commit: 2324d69d24e5540e220c91e46aa07a0962e3b330

This is from Jan 25 scala/scala-parser-combinators@2324d69

[SethTisue]

yeah, so this must have to do with the sbt version bump. @dwijnand can you think of a change in 0.13.16-M1 that could affect this somehow?

the scala-parser-combinators build has scalaVersion in ThisBuild := crossScalaVersions.value.head and then the crossScalaVersions doesn't consult any other keys

[SethTisue]

maybe sbt/sbt@ff017eb ?

[eed3si9n]

maybe sbt/sbt@ff017eb ?

That could be the culprit since I did add scalaVersion at the project level.

[eed3si9n]

I can start up sbt 0.13.16-M1 on 1.0.x branch of scala-parser-combinators, so I'm wondering if the problem was actually to do with AutoPlugin ordering that @dwijnand fixed in scala/sbt-scala-module#20. Will scala/scala-parser-combinators@6cac8c3 be forward ported?

[eed3si9n]

Actually the forward porting was already done 5 days ago in scala/scala-parser-combinators#115, so it should build now.

[SethTisue]

rebased. new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1493/consoleFull

[SethTisue]

[info] >>> The dbuild result is------------: SUCCESS (project rebuilt ok)

[eed3si9n]

Awesome.

[SethTisue]

test run with 0.13.6-RC1: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1689/consoleFull (404 while Jenkins sits and ponders why the little birds flit from branch to branch, couldn't they just sit still?)

UPDATE: doh, I should have merged 2.12.x onto this branch before running

[SethTisue]

new test run: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1690/consoleFull (404 while Jenkins gazes blankly at Warren Harding's deathbed)

[SethTisue]

I think I'm going to merge this even though 0.13.16 is still in release candidates, since it enables building the master branch of MiMa (now that Scala 2.12 support in that repo was merged), which is a pretty nice benefit.

[SethTisue]

sure is dark down here in this rabbit hole

but the bunnies are friendly.... SO FAR

[SethTisue]

the scalafmt part of this is turning out to be especially hard, so I'll make a separate PR out of that

[SethTisue]

ok I think this is done, but we need a full test run to make sure nothing regressed: https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1696/consoleFull