Skip to content

Add XMLDocument #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2023
Merged

Add XMLDocument #804

merged 1 commit into from
Aug 9, 2023

Conversation

armanbilge
Copy link
Member

XMLDocument is essentially just a marker class so this was extremely straightforward. Linking to #771.

@armanbilge armanbilge mentioned this pull request Aug 9, 2023
Open
@armanbilge armanbilge requested a review from zetashift August 9, 2023 06:28
zetashift
zetashift approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@zetashift zetashift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@armanbilge armanbilge merged commit 9d7e1b7 into main Aug 9, 2023
@armanbilge armanbilge deleted the feature/xmldocument branch August 9, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zetashift zetashift zetashift approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armanbilge @zetashift