deprecate Node.isSameNode Node.isSupported. add missing Node.contains #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -943,7 +943,9 @@ class Node extends EventTarget { | |||
| * The Node.isSupported()returns a Boolean flag containing the result of a test | |||
| * whether the DOM implementation implements a specific feature and this feature is | |||
| * supported by the specific node. | |||
| * | |||
| * @deprecated | |||
There was a problem hiding this comment.
@deprecated should be a real annotation, not part of the comment. Otherwise it's not really deprecated.
|
Looks good to me except for the deprecated thing |
Merged
Visbone
pushed a commit
to Visbone/scala-js-dom
that referenced
this pull request
Mar 18, 2021
…n-RC1-docs Fix a link changed in Scala 3.0.0-RC1 reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/Node.isSameNode
https://developer.mozilla.org/en-US/docs/Web/API/Node.isSupported
https://developer.mozilla.org/en-US/docs/Web/API/Node.contains