Skip to content

Revise and add ReadyState classes #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2021
Merged

Revise and add ReadyState classes #617

merged 2 commits into from
Oct 21, 2021

Conversation

japgolly
Copy link
Contributor

Closes #615

@japgolly japgolly requested a review from armanbilge October 21, 2021 06:13
armanbilge
armanbilge approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking all these down, this is definitely the right approach 👍

@armanbilge armanbilge merged commit 4d41914 into master Oct 21, 2021
@armanbilge armanbilge deleted the topic/readyState branch October 21, 2021 06:20
@japgolly
Copy link
Contributor Author

Thanks! A bit tedious but nicer in the end :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadyState is ambiguous
2 participants
@japgolly @armanbilge